git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t8005: avoid grep on non-ASCII data

From
Jeff King <peff@peff.net>
Date
Feb 22, 2016, 22:18 UTC
Message-ID
<20160222221811.GC18522@sigill.intra.peff.net>
In-Reply-To
<20160221234135.GA14382@river.lan>
On Sun, Feb 21, 2016 at 11:41:35PM +0000, John Keeping wrote:
Show 9 quoted lines
> My original sed version was:
> 
> 	sed -ne "/^author /p" -e "/^summary /p"
> 
> which I think will work on all platforms (we already use it in
> t0000-basic.sh) but then I decided to be too clever :-(
> 
> I still think sed is simpler than introducing a new function to wrap a
> perl script.

Yeah, I think that is good (personally I'd use a function anyway, but I think it is short enough that we could go either way).

-Peff
Previous: Eric SunshineNext: Junio C Hamano
Message 16 of 27 in “Test failures with GNU grep 2.23”
  1. John KeepingFeb 7, 2016
  2. Jeff KingFeb 19, 2016
  3. Eric SunshineFeb 19, 2016
  4. Junio C HamanoFeb 19, 2016
  5. Jeff KingFeb 19, 2016
  6. John KeepingFeb 19, 2016
  7. Jeff KingFeb 19, 2016
  8. 0/2 Fix test failures with GNU grep 2.23John Keeping, Feb 21, 2016
  9. 1/2 t8005: avoid grep on non-ASCII dataJohn Keeping, Feb 21, 2016
  10. Eric SunshineFeb 21, 2016
  11. Jeff KingFeb 21, 2016
  12. Eric SunshineFeb 21, 2016
  13. Jeff KingFeb 21, 2016
  14. John KeepingFeb 21, 2016
  15. Eric SunshineFeb 21, 2016
  16. Jeff KingFeb 22, 2016
  17. Junio C HamanoFeb 22, 2016
  18. Junio C HamanoFeb 23, 2016
  19. John KeepingFeb 24, 2016
  20. Junio C HamanoFeb 21, 2016
  21. Eric SunshineFeb 21, 2016
  22. 2/2 t9200: avoid grep on non-ASCII dataJohn Keeping, Feb 21, 2016
  23. Eric SunshineFeb 21, 2016
  24. John KeepingFeb 21, 2016
  25. Eric SunshineFeb 22, 2016
  26. Jeff KingFeb 22, 2016
  27. Junio C HamanoFeb 23, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.