git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] rev-parse: respect core.hooksPath in --git-path

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 17, 2016, 15:40 UTC
Message-ID
<xmqq1t1nbdza.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<594839500.1229861.1471423409171.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:

> I tried to see if the `git config` in other tests were in the
> same case or not but the sheer amount made me reconsider. However
> taking a look at a couple of random ones, there are some scripts
> that would benefit from the conversion.

Yes, that is why I said "it is a good idea to do this where necessary, but the test Dscho touched here does not need it". It is a given that there are tons of "git config" users as we have a lot more tests that were written before test_config was invented.

It is good to occasionally modernise ancient tests; we usually do so when we need to make some other changes to them (e.g. I added a feature, and wanted to add a couple of new tests, but I found it unreadable and unmaintainable because it kept the ancient style, so I am updating the existing tests to more modern style first before doing my changes--and then do my changes on top of the cleaned up codebase).

Previous: Remi Galan Alfonso
Message 11 of 11 in “rev-parse: respect core.hooksPath in --git-path”
  1. rev-parse: respect core.hooksPath in --git-pathJohannes Schindelin, Aug 15, 2016
  2. Jeff KingAug 15, 2016
  3. Johannes SchindelinAug 16, 2016
  4. Jeff KingAug 16, 2016
  5. rev-parse: respect core.hooksPath in --git-pathJohannes Schindelin, Aug 16, 2016
  6. Remi Galan AlfonsoAug 16, 2016
  7. Johannes SchindelinAug 16, 2016
  8. Remi Galan AlfonsoAug 16, 2016
  9. Junio C HamanoAug 16, 2016
  10. Remi Galan AlfonsoAug 17, 2016
  11. Junio C HamanoAug 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.