Re: [PATCH v2] rev-parse: respect core.hooksPath in --git-path

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 16, 2016, 15:55 UTC
Message-ID: <alpine.DEB.2.20.1608161739280.4924@virtualbox>
In-Reply-To: <1134106438.1228353.1471361364992.JavaMail.zimbra@ensimag.grenoble-inp.fr>

Hi Rémi,

On Tue, 16 Aug 2016, Remi Galan Alfonso wrote:

Show 13 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> > diff --git a/t/t1350-config-hooks-path.sh b/t/t1350-config-hooks-path.sh
> > index 5e3fb3a..f1f9aee 100755
> > --- a/t/t1350-config-hooks-path.sh
> > +++ b/t/t1350-config-hooks-path.sh
> > @@ -34,4 +34,10 @@ test_expect_success 'Check that various forms of specifying core.hooksPath work'
> >          test_cmp expect actual
> >  '
> >  
> > +test_expect_success 'git rev-parse --git-path hooks' '
> > +        git config core.hooksPath .git/custom-hooks &&
> 
> Any reason to not use 'test_config' here?

Yes: consistency. The rest of the script uses `git config`, not
`test_config`.

Ciao, Dscho