Re: [PATCH 1/2] ls-files: adding support for submodules

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2016, 22:28 UTC
Message-ID: <xmqq1t0c7ur2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAKoko1q7Mb6_cnaA1ecZJ2y1PWUrW4RSu6RiviyN91JV5-QR5g@mail.gmail.com>

Brandon Williams <bmwill@google.com> writes:

> This is another version of the first ls-files patch i sent out in
> order.  In this version I fixed the option
>  name to be '--submodule-prefix'.

I understand that many internal changes in your work environment are titled like "DOing X", but our convention around here is to label them "DO X", as if you are giving an order to somebody else, either telling the codebase "to be like so", or telling the patch-monkey maintainer "to make it so". So I'd suggest retitling it to

	ls-files: optionally recurse into submodules

or something like that. It is an added advantage of being a lot more descriptive than "adding support", which does not say what kind of support it is adding.