Re: [PATCH v2] commit: make --only --allow-empty work without paths
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 8, 2016, 16:47 UTC
- Message-ID
- <xmqq1sxiv051.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20161208135029.GA16292@inner.h.apk.li>
Andreas Krey <a.krey@gmx.de> writes:
> Ok, I've removed the clever message, as Junio suggested. > I don't know what else to do to make it acceptable. :-) > We're going to deploy it internally anyway, but I think > it belongs in git.git as well (aka 'Can I has "will queue"?').
Oh, sorry for being unclear. Before I started saying "Slightly related topic.", after quoting "The patch itself looks good to me." by Peff, I meant to say "Yeah, this looks good; thanks.", but apparently I forgot.
Removal of "Clever" is a separate issue and it may make sense to do so, but it deserves its own commit with its own justification.
Sorry for making you send an extra round; let's queue the original, and if you still are interested, have the "Clever" removal as its own patch.
Thanks.