git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] commit: make --only --allow-empty work without paths

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 8, 2016, 16:47 UTC
Message-ID
<xmqq1sxiv051.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20161208135029.GA16292@inner.h.apk.li>
Andreas Krey <a.krey@gmx.de> writes:
> Ok, I've removed the clever message, as Junio suggested.
> I don't know what else to do to make it acceptable. :-)
> We're going to deploy it internally anyway, but I think
> it belongs in git.git as well (aka 'Can I has "will queue"?').

Oh, sorry for being unclear. Before I started saying "Slightly related topic.", after quoting "The patch itself looks good to me." by Peff, I meant to say "Yeah, this looks good; thanks.", but apparently I forgot.

Removal of "Clever" is a separate issue and it may make sense to do so, but it deserves its own commit with its own justification.

Sorry for making you send an extra round; let's queue the original, and if you still are interested, have the "Clever" removal as its own patch.

Thanks.
Previous: Andreas KreyNext: Andreas Krey
Message 9 of 10 in “commit: make --only --allow-empty work without paths”
  1. commit: make --only --allow-empty work without pathsAndreas Krey, Dec 2, 2016
  2. Jeff KingDec 3, 2016
  3. Andreas KreyDec 3, 2016
  4. Jeff KingDec 3, 2016
  5. Junio C HamanoDec 5, 2016
  6. Andreas KreyDec 6, 2016
  7. Junio C HamanoDec 5, 2016
  8. commit: make --only --allow-empty work without pathsAndreas Krey, Dec 8, 2016
  9. Junio C HamanoDec 8, 2016
  10. commit: remove 'Clever' message for --only --amendAndreas Krey, Dec 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.