git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] commit: remove 'Clever' message for --only --amend

From
Andreas Krey <a.krey@gmx.de>
Date
Dec 9, 2016, 04:10 UTC
Message-ID
<20161209041021.GB16292@inner.h.apk.li>
In-Reply-To
<xmqq1sxiv051.fsf@gitster.mtv.corp.google.com>

That behavior is now documented, and we don't need a reward afterwards.

Signed-off-by: Andreas Krey <a.krey@gmx.de>
---
> Sorry for making you send an extra round; let's queue the original,
> and if you still are interested, have the "Clever" removal as its
> own patch.
Here you go.
 builtin/commit.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 89b66816f..276c74034 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1208,8 +1208,6 @@ static int parse_and_validate_options(int argc, const char *argv[],
 		die(_("Only one of --include/--only/--all/--interactive/--patch can be used."));
 	if (argc == 0 && (also || (only && !amend && !allow_empty)))
 		die(_("No paths with --include/--only does not make sense."));
-	if (argc == 0 && only && amend)
-		only_include_assumed = _("Clever... amending the last one with dirty index.");
 	if (argc > 0 && !also && !only)
 		only_include_assumed = _("Explicit paths specified without -i or -o; assuming --only paths...");
 	if (!cleanup_arg || !strcmp(cleanup_arg, "default"))
-- 
2.11.0.10.g1e1b186.dirty
Previous: Junio C Hamano
Message 10 of 10 in “commit: make --only --allow-empty work without paths”
  1. commit: make --only --allow-empty work without pathsAndreas Krey, Dec 2, 2016
  2. Jeff KingDec 3, 2016
  3. Andreas KreyDec 3, 2016
  4. Jeff KingDec 3, 2016
  5. Junio C HamanoDec 5, 2016
  6. Andreas KreyDec 6, 2016
  7. Junio C HamanoDec 5, 2016
  8. commit: make --only --allow-empty work without pathsAndreas Krey, Dec 8, 2016
  9. Junio C HamanoDec 8, 2016
  10. commit: remove 'Clever' message for --only --amendAndreas Krey, Dec 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.