Re: [PATCH v2 05/16] ref-filter: add test for --contains on a non-commit

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2017, 18:29 UTC
Message-ID: <xmqq1stqqy9v.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170321125901.10652-6-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change the tag test suite to test for --contains on a tree & blob, it

Either s/, it/. It/ or s/, it/; it/.

Show 5 quoted lines

> only accepts commits and will spew out "<object> is a tree, not a
> commit".
>
> It's sufficient to test this just for the "tag" and "branch" commands,
> because it covers all the machinery is shared between "branch" and

Either s/is shared/shared/ or s/is shared/that is shared/.

> "for-each-ref".
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

The patch itself looks good.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.