From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 21 Mar 2017 18:29:16 GMT
Subject: Re: [PATCH v2 05/16] ref-filter: add test for --contains on a non-commit
Message-ID: <xmqq1stqqy9v.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170321125901.10652-6-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change the tag test suite to test for --contains on a tree & blob, it

Either s/, it/. It/ or s/, it/; it/.

> only accepts commits and will spew out "<object> is a tree, not a
> commit".
>
> It's sufficient to test this just for the "tag" and "branch" commands,
> because it covers all the machinery is shared between "branch" and

Either s/is shared/shared/ or s/is shared/that is shared/.

> "for-each-ref".
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

The patch itself looks good.

Thanks.