Re: Proposal for missing blob support in Git repos

From: Junio C Hamano <gitster@pobox.com>
Date: May 4, 2017, 04:29 UTC
Message-ID: <xmqq1ss5b5xh.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <daed427f-b39e-c3d9-76ee-9c37203e1988@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 12 quoted lines

> I see the semantics as "don't write what you already have", where
> "have" means what you have in local storage, but if you extend "have"
> to what upstream has, then yes, you're right that this changes
> (ignoring shallow clones).
>
> This does remove a resistance that we have against hash collision (in
> that normally we would have the correct object for a given hash and
> can resist other servers trying to introduce a wrong object, but now
> that is no longer the case), but I think it's better than consulting
> the hook whenever you want to write anything (which is also a change
> in semantics in that you're consulting an external source whenever
> you're writing an object, besides the performance implications).

As long as the above pros-and-cons analysis is understood and we are striking a balance between performance and strictness with such an understanding of the implications, I am perfectly fine with the proposal. That is why my comment has never been "I think that is wrong" but consistently was "I wonder if that is a good thing."

Thanks.