git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Proposal for missing blob support in Git repos

From
JTJonathan Tan <jonathantanmy@google.com>
Date
May 4, 2017, 17:09 UTC
Message-ID
<3abf3663-b09d-0196-e719-6cef02f01482@google.com>
In-Reply-To
<xmqq1ss5b5xh.fsf@gitster.mtv.corp.google.com>
On 05/03/2017 09:29 PM, Junio C Hamano wrote:
Show 22 quoted lines
> Jonathan Tan <jonathantanmy@google.com> writes:
>
>> I see the semantics as "don't write what you already have", where
>> "have" means what you have in local storage, but if you extend "have"
>> to what upstream has, then yes, you're right that this changes
>> (ignoring shallow clones).
>>
>> This does remove a resistance that we have against hash collision (in
>> that normally we would have the correct object for a given hash and
>> can resist other servers trying to introduce a wrong object, but now
>> that is no longer the case), but I think it's better than consulting
>> the hook whenever you want to write anything (which is also a change
>> in semantics in that you're consulting an external source whenever
>> you're writing an object, besides the performance implications).
>
> As long as the above pros-and-cons analysis is understood and we are
> striking a balance between performance and strictness with such an
> understanding of the implications, I am perfectly fine with the
> proposal.  That is why my comment has never been "I think that is
> wrong" but consistently was "I wonder if that is a good thing."
>
> Thanks.
Noted - if/when I update the patch, I'll include this information in.
Previous: Junio C Hamano
Message 12 of 12 in “Proposal for missing blob support in Git repos”
  1. Jonathan TanApr 26, 2017
  2. Junio C HamanoMay 1, 2017
  3. Jonathan TanMay 1, 2017
  4. Junio C HamanoMay 1, 2017
  5. Jonathan TanMay 2, 2017
  6. Brandon WilliamsMay 2, 2017
  7. Junio C HamanoMay 2, 2017
  8. Jonathan TanMay 2, 2017
  9. Ævar Arnfjörð BjarmasonMay 2, 2017
  10. Jonathan TanMay 2, 2017
  11. Junio C HamanoMay 4, 2017
  12. Jonathan TanMay 4, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.