Re: [PATCH 0/6] clean up parsing of maybe_bool

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2017, 21:12 UTC
Message-ID: <xmqq1sonozdx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kaEA7DRm4inO=XPCVvA3mJioV_yckAVEUbCo5DEwoxbUQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> The series looks fine to me overall, though patch 5 is overly gentle IMHO.
> We could have removed it right there as Junio is very good at resolving
> conflicts or producing dirty merges for such a situation.
> But delaying it until no other series' are in flight is fine with me, too.

If you remove the old one, it would cause compilation error due to removal of the declaration of the old one when other series that are in flight adds new callsites to it. Which makes life a bit easier for the integrators when it is trivial to convert these callsites to use the new one. If the way the old one and the new one are called are vastly different, of course, leaving the compatibility layer that no longer is used after the series will make it easier to live with other topics in flight, on the other hand.

I am fine with either in this case, but I probably would have opted for removal at the end of this series if I were doing this series, because

- git_config_maybe_bool(K,V) + git_parse_maybe_bool(V)

that may have to happen during evil merges would have been trivial.

Thanks.