[PATCH 2/6] t5334: document that git push --signed=1 does not work
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Aug 7, 2017, 18:20 UTC
- Message-ID
- <4ac17762106cde543c4c60968946b68263830d61.1502128418.git.martin.agren@gmail.com>
- In-Reply-To
- <cover.1502128418.git.martin.agren@gmail.com>
When accepting booleans as command-line or config options throughout Git, there are several documented synonyms for true and false. However, one particular user is slightly broken: `git push --signed=..` does not understand the integer synonyms for true and false.
This is hardly wanted. The --signed option has a different notion of boolean than all other arguments and config options, including the config option corresponding to it, push.gpgSign.
Add a test documenting the failure to handle --signed=1.
Signed-off-by: Martin Ågren <martin.agren@gmail.com> --- t/t5534-push-signed.sh | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/t/t5534-push-signed.sh b/t/t5534-push-signed.sh index 464ffdd14..5dce55e1d 100755 --- a/t/t5534-push-signed.sh +++ b/t/t5534-push-signed.sh @@ -71,6 +71,13 @@ test_expect_success 'push --signed fails with a receiver without push certificat test_i18ngrep "the receiving end does not support" err ' +test_expect_failure 'push --signed=1 is accepted' ' + prepare_dst && + mkdir -p dst/.git/hooks && + test_must_fail git push --signed=1 dst noop ff +noff 2>err && + test_i18ngrep "the receiving end does not support" err +' + test_expect_success GPG 'no certificate for a signed push with no update' ' prepare_dst && mkdir -p dst/.git/hooks &&
-- 2.14.0.5.g0f7b1ed27