Re: [PATCH 0/5] roll back locks in various code paths
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 27, 2018, 23:42 UTC
- Message-ID
- <xmqq1sh6ngof.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <cover.1519763396.git.martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
Show 11 quoted lines
> Patches 2-4 are the actual fixes where I teach some functions to always > roll back the lock they're holding. Notably, these are all in "libgit". > > Patch 1 is a "while at it" to use locks on the stack instead of having > them be static. Patch 5 removes code to roll back locks which are > already rolled back. > > I've based this on maint. There's a conflict on pu, with c7d4394111 > (sequencer: avoid using errno clobbered by rollback_lock_file(), > 2018-02-11). The conflict resolution would be to take my version for the > "could not lock HEAD"-hunk.
Thanks for running a trial merge before sending your patches out. I wish there were more contributors like you ;-)
The changes looked reasonable.