Re: [PATCH 07/17] commit: increase commit message buffer size
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 10, 2018, 16:35 UTC
- Message-ID
- <xmqq1scb9hg6.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180709233952.GB535220@genre.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 7 quoted lines
>> As Brandon alludes to downthread, we probably should use strbuf for >> things like this these days, so a preliminary clean-up to do so is >> probably a welcome change to sneak in and rebase this series on top >> of. > > Sure, I agree that would be a better change, and I'm happy to reroll > with that.
Or we can do the clean-up after this 17-patch series settles, which probably is a better order to do things. It is usually better to make a longer but more mechanical topic like this pass through the system rather quickly, which tends to minimize disruption on other topics.