Re: [PATCH 01/17] cache: update object ID functions for the_hash_algo
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Jul 9, 2018, 02:38 UTC
- Message-ID
- <CA+P7+xq900ikNR3uBEo28rjrTh5iYJm-R8jcAjhq-7G2jh3iVA@mail.gmail.com>
- In-Reply-To
- <20180708233638.520172-2-sandals@crustytoothpaste.net>
On Sun, Jul 8, 2018 at 4:39 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:
Show 6 quoted lines
> static inline int oidcmp(const struct object_id *oid1, const struct object_id *oid2)
> {
> - return hashcmp(oid1->hash, oid2->hash);
> + return memcmp(oid1->hash, oid2->hash, the_hash_algo->rawsz);
> }
>Just curious, what's the reasoning for not using the hashcmp anymore?
Thanks, Jake