Re: [PATCH] pack-protocol.txt: accept error packets in any context

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 29, 2018, 07:49 UTC
Message-ID: <xmqq1s74nx1n.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqqh8g3t7gm.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

>> diff --git a/connect.c b/connect.c
>> index 24281b608..458906e60 100644
>> --- a/connect.c
>> +++ b/connect.c
>> @@ -306,8 +306,6 @@ struct ref **get_remote_heads(struct packet_reader *reader,
>>  			die_initial_contact(1);
>>  		case PACKET_READ_NORMAL:
>>  			len = reader->pktlen;
>> -			if (len > 4 && skip_prefix(reader->line, "ERR ", &arg))
>> -				die(_("remote error: %s"), arg);
>>  			break;
>>  		case PACKET_READ_FLUSH:
>>  			state = EXPECTING_DONE;

This breaks build by not removing the decl of arg while removing the last user of that variable in the function.

 connect.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/connect.c b/connect.c
index 458906e60d..4813f005ab 100644
--- a/connect.c
+++ b/connect.c
@@ -296,7 +296,6 @@ struct ref **get_remote_heads(struct packet_reader *reader,
 	struct ref **orig_list = list;
 	int len = 0;
 	enum get_remote_heads_state state = EXPECTING_FIRST_REF;
-	const char *arg;
 
 	*list = NULL;

-- 
2.20.0-rc1-10-g7068cbc4ab