git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-protocol.txt: accept error packets in any context

From
Masaya Suzuki <masayasuzuki@google.com>
Date
Nov 29, 2018, 16:10 UTC
Message-ID
<CAJB1erVBMq84gXir1YD=3R_RXS+qXYAsPKo6ecEJBBNv-4JOFQ@mail.gmail.com>
In-Reply-To
<xmqqwoowmfzt.fsf@gitster-ct.c.googlers.com>
On Thu, Nov 29, 2018 at 3:42 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
>
> Masaya Suzuki <masayasuzuki@google.com> writes:
>
> > In the Git pack protocol definition, an error packet may appear only in
> > a certain context. However, servers can face a runtime error (e.g. I/O
> > error) at an arbitrary timing. This patch changes the protocol to allow
> > an error packet to be sent instead of any packet.
> >
> > Following this protocol spec change, the error packet handling code is
> > moved to pkt-line.c.
> >
> > Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
> > ---
>
> Have you run tests with this applied?  I noticed 5703.9 now has
> stale expectations, but there may be others.

Yes, I did. And it also didn't end up in a build error. Do I have a different build option...?

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “pack-protocol.txt: accept error packets in any context”
  1. pack-protocol.txt: accept error packets in any contextMasaya Suzuki, Nov 27, 2018
  2. Junio C HamanoNov 27, 2018
  3. Junio C HamanoNov 29, 2018
  4. Junio C HamanoNov 29, 2018
  5. Masaya SuzukiNov 29, 2018
  6. Junio C HamanoNov 30, 2018
  7. Stefan BellerDec 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.