Re: [PATCH v3] repack: enable bitmaps by default on bare repos

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 25, 2019, 07:16 UTC
Message-ID: <xmqq1s1qy2ox.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190410225721.GA32262@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Tue, Apr 09, 2019 at 05:10:43PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> I've found a case where turning bitmaps on does horrible things for
>> bitmap "push" performance.
>> [...]
>> I can't share the repo, but I had a report where just a "git push" of a
>> topic branch that was 2/58 ahead/behind took ~2 minutes just in
>> "Enumerating objects", but ~500ms without bitmaps.
>
> That's pretty bad, though I'm not terribly surprised.

I was revisiting the recent "What's cooking" report, and I am not sure what the current status of the topic is.

I do not get a feel that the current bitmap implementation has been widely used in repositories that have vastly different access patterns---it probably has been tried only by those who can afford the engineering cost to see if the implementation happens to work well for their workload and some may have chosen to adopt it while others didn't. So it may be very well tuned for the former people but once we merge this topic down, we'll hear from others with quite different workload, which may lead to us tuning the code to bit better to their workload while not hurting other existing users, hopefully.

Or not.

I am somewhat tempted to make things more exciting by merging it to 'next' soonish, but I guess Ævar and you are not quite ready for that excitement yet, judging from the following (which looks quite sensible suggestions)?

Thanks.

Show 34 quoted lines

> Yeah, that makes sense. By repacking you've taken all those new commits
> and included them in on-disk bitmaps. So I'd expect the "wants" to get
> much shorter, but the "haves" phase staying long means we could do a
> better job of picking commits to have on-disk bitmaps.
>
> So two avenues for exploration I think:
>
>   1. I've long suspected that the bitmap selection code isn't ideal.
>      Both in terms of what it picks, but also in its runtime (I think it
>      ends up walking the same slices of history multiple times in some
>      cases).
>
>   2. The answer we get from a bitmap versus a regular traversal are not
>      apples-to-apples equivalent. The regular traversal walks down to
>      the UNINTERESTING commits, marks the boundaries trees and blobs as
>      UNINTERESTING, and then adds in all the interesting trees and blobs
>      minus the UNINTERESTING parts. So it can sometimes give the wrong
>      answer, claiming something is interesting when it is not.
>
>      Whereas with bitmaps we fill in the trees and blobs as we walk, and
>      you get the true answer. But it means we may open up a lot more
>      trees than the equivalent traversal would.
>
>      So one thing I've never really experimented with (and indeed, never
>      really thought about until writing this email) is that the bitmaps
>      could try to do that looser style of traversal, knowing that we
>      might err on the side of calling things interesting in a few cases.
>      But hopefully spending a lot less time opening trees.
>
>      I'm not even 100% sure what that would look like in code, but just
>      thinking about it from a high level, I don't there's a particular
>      mathematical reason it couldn't work.
>
> -Peff