Re: [PATCH v2 1/2] path: add a function to check for path suffix

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2019, 00:32 UTC
Message-ID: <xmqq1rxrcjfp.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190811174748.33552-2-sandals@crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 5 quoted lines

> We have a function to strip the path suffix from a commit, but we don't
> have one to check for a path suffix. For a plain filename, we can use
> basename, but that requires an allocation, since POSIX allows it to
> modify its argument. Refactor strip_path_suffix into a helper function
> and a new function, has_path_suffix to meet this need.

I wish we did not use a crazy phrase "path suffix", that would inevitably confuse ourselves with things like ".exe".

>  /*
> + * If path ends with suffix (complete path components), returns the offset of
> + * the last character in the path before the suffix (sans trailing directory
> + * separators), and -1 otherwise.

i.e. this is offset to the last path component.

> +static ssize_t stripped_path_suffix_offset(const char *path, const char *suffix)

Perhaps

    static ssize_t last_path_component_offset(const char *path, const char *name)

I am tempted to also call the second parameter to this function "basename", as we know from the proposed log message that you wish "basename" were usable for this purpose, but basename itself has another confusing factor (i.e. "are we stripping ".exe" extension?", to which the answer is no in the context of these functions).

If we agree with the "last path component" phrasing, has_path_suffix() would become something like:

    int last_path_component_equals(const char *path, const char *name);

perhaps.