git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 0/2] Honor .gitattributes with rebase --am

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Aug 18, 2019, 18:44 UTC
Message-ID
<20190818184403.861907-1-sandals@crustytoothpaste.net>
In-Reply-To
<20190809100217.427178-1-sandals@crustytoothpaste.net>

This series makes rebase --am honor the .gitattributes file for subsequent patches when a patch changes it.

Changes from v3:
* Check for both addition and removal of .gitattributes files.
* Switch from "test_config" to "git config".
Changes from v2:
* Rename has_path_suffix to ends_with_path_components.
Changes from v1:
* Add has_path_suffix in a separate commit.
brian m. carlson (2):
  path: add a function to check for path suffix
  apply: reload .gitattributes after patching it
 apply.c           |  7 +++++++
 convert.c         |  9 ++++++++-
 convert.h         |  6 ++++++
 path.c            | 39 ++++++++++++++++++++++++++++++---------
 path.h            |  3 +++
 t/t3400-rebase.sh | 36 ++++++++++++++++++++++++++++++++++++
 6 files changed, 90 insertions(+), 10 deletions(-)
Range-diff against v3:
1:  5f4402b38d ! 1:  fa825e4b40 apply: reload .gitattributes after patching it
    @@ apply.c: static int apply_patch(struct apply_state *state,
      			*listp = patch;
      			listp = &patch->next;
     +
    -+			if (!flush_attributes && patch->new_name &&
    -+			    ends_with_path_components(patch->new_name, GITATTRIBUTES_FILE))
    ++			if ((patch->new_name && ends_with_path_components(patch->new_name, GITATTRIBUTES_FILE)) ||
    ++			    (patch->old_name && ends_with_path_components(patch->old_name, GITATTRIBUTES_FILE)))
     +				flush_attributes = 1;
      		}
      		else {
    @@ t/t3400-rebase.sh: test_expect_success 'rebase --am and --show-current-patch' '
     +	(
     +		cd attributes &&
     +		test_commit init &&
    -+		test_config filter.test.clean "sed -e '\''s/smudged/clean/g'\''" &&
    -+		test_config filter.test.smudge "sed -e '\''s/clean/smudged/g'\''" &&
    ++		git config filter.test.clean "sed -e '\''s/smudged/clean/g'\''" &&
    ++		git config filter.test.smudge "sed -e '\''s/clean/smudged/g'\''" &&
     +
     +		test_commit second &&
     +		git checkout -b test HEAD^ &&
    @@ t/t3400-rebase.sh: test_expect_success 'rebase --am and --show-current-patch' '
     +		echo "This text is smudged." >a.txt &&
     +		git add a.txt &&
     +		test_commit fourth &&
    ++
    ++		git checkout -b removal HEAD^ &&
    ++		git rm .gitattributes &&
    ++		git add -u &&
    ++		test_commit fifth &&
    ++		git cherry-pick test &&
    ++
    ++		git checkout test &&
     +		git rebase master &&
    -+		grep "smudged" a.txt
    ++		grep "smudged" a.txt &&
    ++
    ++		git checkout removal &&
    ++		git reset --hard &&
    ++		git rebase master &&
    ++		grep "clean" a.txt
     +	)
     +'
     +
Previous: brian m. carlsonNext: brian m. carlson
Message 29 of 41 in “apply: reload .gitattributes after patching it”
  1. apply: reload .gitattributes after patching itbrian m. carlson, Aug 9, 2019
  2. Taylor BlauAug 9, 2019
  3. brian m. carlsonAug 9, 2019
  4. Jeff KingAug 9, 2019
  5. brian m. carlsonAug 9, 2019
  6. SZEDER GáborAug 9, 2019
  7. Jeff KingAug 9, 2019
  8. brian m. carlsonAug 9, 2019
  9. 0/2 Honor .gitattributes with rebase --ambrian m. carlson, Aug 11, 2019
  10. 1/2 path: add a function to check for path suffixbrian m. carlson, Aug 11, 2019
  11. Junio C HamanoAug 12, 2019
  12. brian m. carlsonAug 12, 2019
  13. SZEDER GáborAug 12, 2019
  14. Junio C HamanoAug 12, 2019
  15. brian m. carlsonAug 12, 2019
  16. Jeff KingAug 13, 2019
  17. Junio C HamanoAug 13, 2019
  18. SZEDER GáborAug 13, 2019
  19. Junio C HamanoAug 13, 2019
  20. 2/2 apply: reload .gitattributes after patching itbrian m. carlson, Aug 11, 2019
  21. 0/2 Honor .gitattributes with rebase --ambrian m. carlson, Aug 13, 2019
  22. 1/2 path: add a function to check for path suffixbrian m. carlson, Aug 13, 2019
  23. 2/2 apply: reload .gitattributes after patching itbrian m. carlson, Aug 13, 2019
  24. Junio C HamanoAug 13, 2019
  25. Junio C HamanoAug 15, 2019
  26. brian m. carlsonAug 16, 2019
  27. Junio C HamanoAug 13, 2019
  28. brian m. carlsonAug 13, 2019
  29. 0/2 Honor .gitattributes with rebase --ambrian m. carlson, Aug 18, 2019
  30. 1/2 path: add a function to check for path suffixbrian m. carlson, Aug 18, 2019
  31. 2/2 apply: reload .gitattributes after patching itbrian m. carlson, Aug 18, 2019
  32. Phillip WoodAug 19, 2019
  33. Phillip WoodAug 19, 2019
  34. brian m. carlsonAug 20, 2019
  35. Phillip WoodAug 20, 2019
  36. brian m. carlsonAug 20, 2019
  37. Phillip WoodAug 20, 2019
  38. Junio C HamanoAug 20, 2019
  39. Phillip WoodAug 20, 2019
  40. Phillip WoodAug 26, 2019
  41. Junio C HamanoAug 26, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.