Re: [PATCH] t1092: use GIT_PROGRESS_DELAY for consistent results
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 25, 2021, 20:46 UTC
- Message-ID
- <xmqq1r9uee3r.fsf@gitster.g>
- In-Reply-To
- <9d6568ee-c9bf-b349-d1a6-0bb2fcf06dab@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 16 quoted lines
> On 5/25/2021 2:32 AM, Junio C Hamano wrote: >> Derrick Stolee <stolee@gmail.com> writes: >> >>>> So we silently convert -1 to 2^64-1, and call it a day. >>> >>> That works for me. I'll send a v2 with that tomorrow unless someone >>> presents a better option. >> >> I'll queue with this tweak for tonight's integration run. >> >> ... > Thank you for proactively modifying the patch. This works > for me. I didn't realize that this was affecting other > contributors [1] until I woke up this morning. > > [1] https://lore.kernel.org/git/036b01d750ed$642b75c0$2c826140$@nexbridge.com/
Well, not so well X-<. It seems that some builds are not happy with this change. See https://github.com/git/git/actions/runs/876229761 specifically these two:
https://github.com/git/git/runs/2669177395?check_suite_focus=true#step:7:3549
https://github.com/git/git/runs/2669080101?check_suite_focus=true#step:6:988I suspect that it has something to do with 32-bit platforms?
Thanks.