Re: [PATCH] t1092: use GIT_PROGRESS_DELAY for consistent results

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 24, 2021, 20:28 UTC
Message-ID: <YKwMU13DOtTIgaeP@google.com>
In-Reply-To: <pull.960.git.1621886108515.gitgitgadget@gmail.com>

Hi,

Derrick Stolee wrote:

Show 6 quoted lines

> The t1092-sparse-checkout-compatibility.sh tests compare the stdout and
> stderr for several Git commands across both full checkouts, sparse
> checkouts with a full index, and sparse checkouts with a sparse index.
> Since these are direct comparisons, sometimes a progress indicator can
> flush at unpredictable points, especially on slower machines. This
> causes the tests to be flaky.

Hm, I think this test strategy is going to be fundamentally flaky regardless: Git doesn't intend to guarantee any kind of stability in the exact stderr output it writes.

Could the tests be made to check more semantically meaningful information such as "git ls-files -s" output instead?

Thanks, Jonathan