Re: [PATCH] Add pcre2 support for cmake build system.

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2022, 22:02 UTC
Message-ID: <xmqq1qwqts6w.fsf@gitster.g>
In-Reply-To: <pull.1267.git.git.1652846305514.gitgitgadget@gmail.com>

"Yuyi Wang via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 8 quoted lines

> From: Yuyi Wang <Strawberry_Str@hotmail.com>
>
> This commit fixes one of the TODOs listed in the CMakeLists.txt.
>
> There's also some small fix to ensure it builds successfully.
>
> Signed-off-by: Yuyi Wang <Strawberry_Str@hotmail.com>
> ---

I haven't worked on the CMakeLists but is the above description sufficient to tell what is going on if given to those who are familiar with it (I ask because it is not clear at all to me).

Show 11 quoted lines

> diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
> index 185f56f414f..99d6cb963c4 100644
> --- a/contrib/buildsystems/CMakeLists.txt
> +++ b/contrib/buildsystems/CMakeLists.txt
> @@ -54,7 +54,7 @@ set(CMAKE_SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}/../..)
>  
>  option(USE_VCPKG "Whether or not to use vcpkg for obtaining dependencies.  Only applicable to Windows platforms" ON)
>  if(NOT WIN32)
> -	set(USE_VCPKG OFF CACHE BOOL FORCE)
> +	set(USE_VCPKG OFF CACHE BOOL "" FORCE)
>  endif()

Is this "small fix to ensure it builds successfully"? To those who do not need/want to use pcre2, is this hunk still needed to "build successfully", or is this something that becomes necessary only because we have other hunks in this patch to add support to pcre2?

If the former, then perhaps the change deserves to be its own patch with own explanation why it is necessary, what breaks without it, etc.

Thanks.