git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add pcre2 support for cmake build system.

From
Derrick Stolee <derrickstolee@github.com>
Date
May 23, 2022, 18:36 UTC
Message-ID
<75aa1726-dca2-5e4b-387e-229e1501209e@github.com>
In-Reply-To
<xmqq1qwqts6w.fsf@gitster.g>
On 5/18/22 6:02 PM, Junio C Hamano wrote:
Show 14 quoted lines
> "Yuyi Wang via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Yuyi Wang <Strawberry_Str@hotmail.com>
>>
>> This commit fixes one of the TODOs listed in the CMakeLists.txt.
>>
>> There's also some small fix to ensure it builds successfully.
>>
>> Signed-off-by: Yuyi Wang <Strawberry_Str@hotmail.com>
>> ---
> 
> I haven't worked on the CMakeLists but is the above description
> sufficient to tell what is going on if given to those who are
> familiar with it (I ask because it is not clear at all to me).

I had the same confusion. Perhaps the message could indicate how one could test this PCRE2 compilation so we could try it out ourselves?

Thanks, -Stolee

Previous: Derrick StoleeNext: Yuyi Wang via GitGitGadget
Message 5 of 9 in “Add pcre2 support for cmake build system.”
  1. Add pcre2 support for cmake build system.Yuyi Wang via GitGitGadget, May 18, 2022
  2. Junio C HamanoMay 18, 2022
  3. Yuyi WangMay 19, 2022
  4. Derrick StoleeMay 23, 2022
  5. Derrick StoleeMay 23, 2022
  6. 0/2 Add pcre2 support for cmake build system.Yuyi Wang via GitGitGadget, May 24, 2022
  7. 1/2 Fix CMakeLists.txt on Linux.Yuyi Wang via GitGitGadget, May 24, 2022
  8. Junio C HamanoMay 24, 2022
  9. 2/2 Add pcre2 support for cmake build system.Yuyi Wang via GitGitGadget, May 24, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.