Re: [PATCH 0/4] midx: trace2 regions and grab-bag patches

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2022, 20:35 UTC
Message-ID: <xmqq1qrbfoms.fsf@gitster.g>
In-Reply-To: <fa47a48b-6da7-a456-05d6-cd5c17b159c3@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 21 quoted lines

> On 10/12/2022 6:01 PM, Taylor Blau wrote:
>> Here is a small handful of MIDX and MIDX bitmap-related patches that
>> I've been carrying in GitHub's fork for a while now and forgot to send
>> upstream.
>> 
>> The first is a small typofix, and the second is a legitimate bug fix
>> which allows us to consider annotated tags as bitmap candidates during
>> commit selection. The final two are trace2 regions and instrumentation
>> that I've found helpful when rolling out MIDX bitmaps in a production
>> setting.
>> 
>> Sorry that these are so disjointed in nature ;-). I figured that it was
>> better to send a grab-bag series like this than to hold onto these
>> patches forever!
>
> As advertised, this set of patches are all nice and small. I've found
> the additional tracing useful during performance investigations and
> unobtrusive otherwise.
>
> Though they looked familiar, I gave them a careful read and have no
> comments. LGTM.

Yeah, they look good to me, too.

Thanks, both.