git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] midx: trace2 regions and grab-bag patches

From
Derrick Stolee <derrickstolee@github.com>
Date
Oct 13, 2022, 13:10 UTC
Message-ID
<fa47a48b-6da7-a456-05d6-cd5c17b159c3@github.com>
In-Reply-To
<cover.1665612094.git.me@ttaylorr.com>
On 10/12/2022 6:01 PM, Taylor Blau wrote:
Show 13 quoted lines
> Here is a small handful of MIDX and MIDX bitmap-related patches that
> I've been carrying in GitHub's fork for a while now and forgot to send
> upstream.
> 
> The first is a small typofix, and the second is a legitimate bug fix
> which allows us to consider annotated tags as bitmap candidates during
> commit selection. The final two are trace2 regions and instrumentation
> that I've found helpful when rolling out MIDX bitmaps in a production
> setting.
> 
> Sorry that these are so disjointed in nature ;-). I figured that it was
> better to send a grab-bag series like this than to hold onto these
> patches forever!

As advertised, this set of patches are all nice and small. I've found the additional tracing useful during performance investigations and unobtrusive otherwise.

Though they looked familiar, I gave them a careful read and have no comments. LGTM.

Thanks, -Stolee

Previous: Taylor BlauNext: Junio C Hamano
Message 6 of 7 in “midx: trace2 regions and grab-bag patches”
  1. 0/4 midx: trace2 regions and grab-bag patchesTaylor Blau, Oct 12, 2022
  2. 1/4 midx.c: fix whitespace typoTaylor Blau, Oct 12, 2022
  3. 2/4 midx.c: consider annotated tags during bitmap selectionTaylor Blau, Oct 12, 2022
  4. 3/4 midx.c: instrument MIDX and bitmap generation with trace2 regionsTaylor Blau, Oct 12, 2022
  5. 4/4 pack-bitmap-write.c: instrument number of reused bitmapsTaylor Blau, Oct 12, 2022
  6. Derrick StoleeOct 13, 2022
  7. Junio C HamanoOct 13, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.