git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: FYI: git issues with libcurl 8.0/1 HTTPS push

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2023, 16:59 UTC
Message-ID
<xmqq1qfvm2rx.fsf@gitster.g>
In-Reply-To
<4q22785-1qr2-824o-806r-26srs4r8p34@unkk.fr>
Daniel Stenberg <daniel@haxx.se> writes:
Show 6 quoted lines
> The downside with this approach is that you make it build-time. Since
> libcurl 8.2.x is binary compatible with the previous versions, users
> could easily upgrade to a newer libcurl without rebuilding git and
> then unnecessarily have the avoid-h2 code still used.
>
> The ideal approach would do the check in run-time to avoid that.

True. I however suspect that the ship has already sailed for our use of libcurl with how git-curl-compat.h uses LIBCURL_VERSION_NUM for other things already. A binary of Git built with older libcurl versions would have compiled out certain features and would still work with newer libcurl.

Thanks.
Previous: Daniel Stenberg
Message 4 of 4 in “FYI: git issues with libcurl 8.0/1 HTTPS push”
  1. Daniel StenbergAug 22, 2023
  2. Junio C HamanoAug 22, 2023
  3. Daniel StenbergAug 22, 2023
  4. Junio C HamanoAug 22, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.