git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: FYI: git issues with libcurl 8.0/1 HTTPS push

From
Daniel Stenberg <daniel@haxx.se>
Date
Aug 22, 2023, 16:42 UTC
Message-ID
<4q22785-1qr2-824o-806r-26srs4r8p34@unkk.fr>
In-Reply-To
<xmqq7cpnm48k.fsf@gitster.g>
On Tue, 22 Aug 2023, Junio C Hamano wrote:
Show 5 quoted lines
> The following is admittedly a very blunt workaround to disable HTTP/2 for 
> the affected versions for any purpose, but I wonder if it is an acceptable 
> workaround.  The remote-curl transport helper is used for both push and 
> fetch and I didn't find a good place to automatically force the protocol 
> version only for pushes.

The downside with this approach is that you make it build-time. Since libcurl 8.2.x is binary compatible with the previous versions, users could easily upgrade to a newer libcurl without rebuilding git and then unnecessarily have the avoid-h2 code still used.

The ideal approach would do the check in run-time to avoid that.

Wether the problem is serious enough to actually warrant such a work-around in the first place, I really cannot say.

-- 
  / daniel.haxx.se
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “FYI: git issues with libcurl 8.0/1 HTTPS push”
  1. Daniel StenbergAug 22, 2023
  2. Junio C HamanoAug 22, 2023
  3. Daniel StenbergAug 22, 2023
  4. Junio C HamanoAug 22, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.