Re: [PATCH GSoC] repo: Remove unnecessary variable shadow

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2026, 19:11 UTC
Message-ID: <xmqq1pi6q9wm.fsf@gitster.g>
In-Reply-To: <CA+rGoLeppg4Xaoqg6+SZ=ET=ze6rXUbmjLm5UvmitmRGm9u6ag@mail.gmail.com>

JAYATHEERTH K <jayatheerthkulkarni2005@gmail.com> writes:

> I got a review on this patch,
> if no one has an issue I wanted to remind it for the next cycle.

Thanks.

An easier way to ping is to resubmit exactly the same patch, with reviewed-by: or acked-by: trailer crediting the reviewer. We have 2000+ messages in 4 weeks, so "I got a review on this patch" without a pointer is much less useful to verify what feedback came to the thread from whom. FYI here are from the headers of the message I am responding to.

    References: <20260223135248.127935-1-jayatheerthkulkarni2005@gmail.com>
    Message-ID: <CA+rGoLeppg4Xaoqg6+SZ=ET=ze6rXUbmjLm5UvmitmRGm9u6ag@mail.gmail.com>

The reference points at the patch itself, and just like Git commits do not have pointers to their children, the original patch message has no links to reviews on it X-<.

I'll commit this with the following change now.

Thanks.

1:  006c49ee01 ! 1:  a66c8c7f91 repo: Remove unnecessary variable shadow
    @@ Metadata
     Author: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
     
      ## Commit message ##
    -    repo: Remove unnecessary variable shadow
    +    repo: remove unnecessary variable shadow
     
         Avoid redeclaring `entry` inside the conditional block, removing
         unnecessary variable shadowing and improving code clarity without
         changing behavior.
     
         Signed-off-by: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
    +    Acked-by: Justin Tobler <jltobler@gmail.com>
         Signed-off-by: Junio C Hamano <gitster@pobox.com>
     
      ## builtin/repo.c ##