git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] commit-graph: fix writing generations with dates exceeding 34 bits

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 24, 2026, 15:42 UTC
Message-ID
<xmqq1ph92pzs.fsf@gitster.g>
In-Reply-To
<20260324-pks-commit-graph-overflow-v2-1-843568cf8780@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> Changes in v2:
>   - Account for platforms where `timestamp_t` has 32 bit precision. This
>     matches logic in `write_graph_chunk_data()`, where we also depend on
>     the size of the commit timestamps.
Show 8 quoted lines
> +static timestamp_t compute_generation_offset(struct commit *c)
> +{
> +	timestamp_t masked_date;
> +
> +	if (sizeof(timestamp_t) > 4)
> +		masked_date = c->date & (((timestamp_t) 1 << 34) - 1);
> +	else
> +		masked_date = c->date;

It is a bit surprising that on a platform where timestamp_t is only 32-bit wide, a smart-enough compiler would not find (1<<34) as suspicious. IOW, I would have expected this to be done not with runtime switch but with conditional compilation.

Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 6 of 8 in “commit-graph: fix writing generations with dates exceeding 34 bits”
  1. commit-graph: fix writing generations with dates exceeding 34 bitsPatrick Steinhardt, Mar 17, 2026
  2. Junio C HamanoMar 17, 2026
  3. Patrick SteinhardtMar 19, 2026
  4. Derrick StoleeMar 20, 2026
  5. commit-graph: fix writing generations with dates exceeding 34 bitsPatrick Steinhardt, Mar 24, 2026
  6. Junio C HamanoMar 24, 2026
  7. Patrick SteinhardtMar 25, 2026
  8. Karthik NayakMar 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.