Re: [PATCH] commit-graph: fix writing generations with dates exceeding 34 bits
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Mar 20, 2026, 17:21 UTC
- Message-ID
- <0566e178-4f12-4647-a257-29631a769b49@gmail.com>
- In-Reply-To
- <abueHjVHCztQtL6b@pks.im>
On 3/19/2026 2:56 AM, Patrick Steinhardt wrote:
Show 16 quoted lines
> On Tue, Mar 17, 2026 at 12:39:39PM -0700, Junio C Hamano wrote: >> Patrick Steinhardt <ps@pks.im> writes: >> >>> this fixes a regression recently introduced by myself in 024b4c9697 >>> (commit: make `repo_parse_commit_no_graph()` more robust, 2026-02-16). >>> The regression was found by GitLab's tests suite, see [1]. >> >> Curious. GitLab's test suite runs pretending that it is way past >> year 2600 or something? > > No, but one of the test repositories that we're running tests with [1] > contains such a commit. > > Patrick > > [1]: https://gitlab.com/gitlab-org/gitlab-test
I'm glad you have this test! Thanks for bringing such a data shape into the Git test suite with this change so we can correct problems this way in our inner loop testing.
I agree with Junio that the code looks good.
Thanks, -Stolee