[PATCH] repo_config_values: freeze the structure for now
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 3, 2026, 19:52 UTC
- Message-ID
- <xmqq1p917kwl.fsf@gitster.g>
The configuration and settings per repository is currently in an unfortunate mess. Especially given that repo_config_values() cannot work on any repository instance other than the_repository, moving more members into this structure is unwelcome.
Acked-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com> ---
* Just for wider visibility. This is a resend of the patch in https://lore.kernel.org/git/xmqqh5hzjdwr.fsf_-_@gitster.g/
environment.h | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/environment.h b/environment.h index 49c86e8879..87b0ab7251 100644 --- a/environment.h +++ b/environment.h @@ -123,6 +123,13 @@ enum object_creation_mode { OBJECT_CREATION_USES_RENAMES = 1 }; +/* + * See https://lore.kernel.org/git/anlmwaEtwcCPse1N@pks.im/ and later + * discussions. Until we figure out what to do with this and + * repo_settings, and allow them to be truly usable on a repository + * instance that is not the_repository, do *NOT* add any new members + * to this structure. + */ struct repo_config_values { /* section "core" config values */ char *attributes_file;
-- 2.56.0-511-g14903f623d