Re: [PATCH] repo_config_values: freeze the structure for now
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Nov 4, 2026, 16:13 UTC
- Message-ID
- <cfa38152-2fca-4734-94df-bcac44fb499d@gmail.com>
- In-Reply-To
- <aurSZcNENBrgxowu@pks.im>
On 11/4/2026 1:36 AM, Patrick Steinhardt wrote:
Show 11 quoted lines
> On Tue, Nov 03, 2026 at 11:52:10AM -0800, Junio C Hamano wrote: >> The configuration and settings per repository is currently in an >> unfortunate mess. Especially given that repo_config_values() cannot >> work on any repository instance other than the_repository, moving >> more members into this structure is unwelcome. >> >> Acked-by: Patrick Steinhardt <ps@pks.im> >> Signed-off-by: Junio C Hamano <gitster@pobox.com> > > You already got my Acked-by, but let me state explicitly that I'm happy > with this change. Thanks!
I will also contribute my +1 to this. This has grown organically, but clearly needs a redesign from first principles to avoid making the situation worse.
Thanks, -Stolee