Re: [PATCH] config: support remote name in includeIf.hasconfig condition

From: Ken Matsui <ken@kmatsui.me>
Date: Oct 20, 2024, 15:43 UTC
Message-ID: <xalChncOvSTxgRdafL-WiQtTfzneMRmhnIFHbEYeRLFYTHgdghc-Js34ml_XpkMBJQNPk68Jj2Q_aAZR73mhLig_Pmv_DSmweukWWqVDLLM=@kmatsui.me>
In-Reply-To: <2a9a4371-958f-491e-b78b-6d4da51483f2@app.fastmail.com>

On Sunday, October 20th, 2024 at 11:33 AM, Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com> wrote:

Show 17 quoted lines

> 
> 
> Hi
> 
> On Sun, Oct 20, 2024, at 17:23, Ken Matsui wrote:
> 
> > Before this patch, includeIf.hasconfig only accepted remote.*.url,
> 
> 
> The conventional description of the current state of the code, without
> this patch, is the present tense. What the patch does uses the
> imperative mood. E.g.
> 
> includeIf.hasconfig only accepts remote.*.url
> 
> See Documentation/SubmittingPatches, “present-tense” and
> “imperative-mood”.

Oops, thank you for pointing this out. I will update the description and send an updated patch.

> 
> --
> Kristoffer Haugsbakk