Re: [PATCH] config: support remote name in includeIf.hasconfig condition

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 20, 2024, 15:33 UTC
Message-ID: <2a9a4371-958f-491e-b78b-6d4da51483f2@app.fastmail.com>
In-Reply-To: <20241020152323.90543-1-ken@kmatsui.me>

Hi

On Sun, Oct 20, 2024, at 17:23, Ken Matsui wrote:

> Before this patch, includeIf.hasconfig only accepted remote.*.url,

The conventional description of the current state of the code, without this patch, is the present tense. What the patch does uses the imperative mood. E.g.

    includeIf.hasconfig only accepts remote.*.url

See Documentation/SubmittingPatches, “present-tense” and “imperative-mood”.

-- 
Kristoffer Haugsbakk