Re: nd/setup

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Apr 11, 2010, 17:57 UTC
Message-ID: <w2mfcaeb9bf1004111057g58cefafdqc1cc30a8c9f82032@mail.gmail.com>
In-Reply-To: <20100408214233.GA32441@progeny.tock>

2010/4/8 Jonathan Nieder <jrnieder@gmail.com>:

Show 11 quoted lines

> Jeff King wrote:
>> On Wed, Apr 07, 2010 at 05:48:02PM -0700, Junio C Hamano wrote:
>
>>> * nd/setup (2010-04-05) 43 commits
> [...]
>> Probably one or both
>> of us should look at it before applying it to next, but assuming it
>> passes a basic sanity check, I think the best thing will be to get it in
>> 'next' early so we can shake out any bugs during the next cycle.
>
> I don’t think it’s anywhere near master material yet.

No it's not. I spent a bit of time on it this morning. A few notes:

- My logic to restore repo state in run_builtin, patch "Guard
unallowed access..", is just broken, and will lead to many die()s (or
warning()s with the squash)
 - "git -p init" will not work, pager problem again.

-- 
Duy