Re: nd/setup

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Apr 9, 2010, 05:46 UTC
Message-ID: <q2pfcaeb9bf1004082246w3fb6e18bw21943150cbeeb5c7@mail.gmail.com>
In-Reply-To: <20100408214233.GA32441@progeny.tock>

2010/4/8 Jonathan Nieder <jrnieder@gmail.com>:

Show 9 quoted lines

> When lockdep finds a locking problem, it quietly prints a message to
> the kernel log and the kernel is able to keep going without worrying
> about it.  Unfortunately, the repository access checker from nd/setup
> is not so graceful: it makes git die even though it should be able to
> carry on just fine.  Example: with nd/setup, ls-remote currently fails
> when run outside any repository.  Probably the checker should be
> configured by an environment variable that indicates where to print
> its messages and whether to bail out when a problem is detected (for
> tests).

The intention was to let that patch stay on next/pu for very long time (or ever), while the rest of fixes can be merged up to master. That's why it was the last patch (now close to the last).

I did use an env variable to control whether it die() when unallowed access is found in early versions. Perhaps I should resurrect that env variable.

> A few of the earlier patches seem iffy, though they all start with a
> correct idea.  For example, one of them changes the semantics of
> rev-parse --show-prefix without documenting it.  So I have been looking

You meant "rev-parse --git-dir"?

-- 
Duy