Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 22, 2010, 08:11 UTC
Message-ID: <vpqzkxkorzr.fsf@bauges.imag.fr>
In-Reply-To: <7vtyo4a096.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 23 quoted lines

> Pat Thoyts <patthoyts@users.sourceforge.net> writes:
>
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
>>>Hi,
>>>
>>>I reported this bug a while ago:
>>>
>>>http://kerneltrap.org/mailarchive/git/2010/2/22/24038
>>>
>>>In short, the "Show history context" item of the context menu of "git
>>>gui blame" is broken since february. Two patches were proposed:
>>>
>>>http://thread.gmane.org/gmane.comp.version-control.git/140688
>>>http://thread.gmane.org/gmane.comp.version-control.git/140288
>>>
>>>But I've just noticed that none of theme were applied.
>>
>> Checking this it seems you are correct. This has been fixed for
>> msysGit with the above patch included there but is missing from
>> git-gui itself and hence missing from core git.
>
> Can we resolve this before 1.7.2 final?

Too late for the 1.7.2, but can we finally get one of these patches applied? They're both very short and straightforward, and fix an important feature of git-gui which is basically broken as of now.

Thanks,

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/