Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 12, 2010, 20:55 UTC
Message-ID: <7vtyo4a096.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87sk3qrjk3.fsf@fox.patthoyts.tk>

Pat Thoyts <patthoyts@users.sourceforge.net> writes:

Show 19 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>>Hi,
>>
>>I reported this bug a while ago:
>>
>>http://kerneltrap.org/mailarchive/git/2010/2/22/24038
>>
>>In short, the "Show history context" item of the context menu of "git
>>gui blame" is broken since february. Two patches were proposed:
>>
>>http://thread.gmane.org/gmane.comp.version-control.git/140688
>>http://thread.gmane.org/gmane.comp.version-control.git/140288
>>
>>But I've just noticed that none of theme were applied.
>
> Checking this it seems you are correct. This has been fixed for
> msysGit with the above patch included there but is missing from
> git-gui itself and hence missing from core git.

Can we resolve this before 1.7.2 final?

Shawn, I see 9c898a1 (git-gui: check whether systems nice command works or disable it, 2010-02-07) on your 'maint' that is not in mine (and a merge of that commit on your 'master'), but neither of these.