Re: [PATCH v2] pager: remove 'S' from $LESS by default

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 6, 2014, 18:49 UTC
Message-ID: <vpqzjiuu4i5.fsf@anie.imag.fr>
In-Reply-To: <87mweuss7d.fsf@fencepost.gnu.org>

David Kastrup <dak@gnu.org> writes:

Show 16 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> I still find the output from "git blame" disturbing, though.  The
>> first thing I do in "git blame" output is to scroll to the right in
>> order to identify the the area I am interested in, and this first
>> step is not negatively affected, because the right scrolled output 
>> automatically wraps long lines.
>>
>> But my second step is to scroll back to the left edge to find the
>> commit object name and at that point, the new default output without
>> "S" gets somewhat annoying, because most of the output lines from
>> "git blame" are longer than my window width.
>
> git blame sucks in anything but fullscreen either way.  It would help to
> display _only_ the source code and have the other info as mouse-over,
> but that's not something a pager can do.

Exactly. I personally never use "git blame" outside "git gui blame" for this reason.

It's possible for a user to set pager.blame to "less -S" to get back to the previous behavior only for blame.

The idea of having a separate default value for pager.blame (or set $LESS differently for blame) crossed my mind, but I actually don't like it, as it would make it harder for a user to fine-tune his configuration manually (one would have to cancel all the corner-cases that Git would set by default).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/