Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Apr 29, 2014, 12:29 UTC
- Message-ID
- <vpq4n1cxqrp.fsf@anie.imag.fr>
- In-Reply-To
- <xmqqk3a9qoib.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 19 quoted lines
> Jeff King <peff@peff.net> writes: > >> On Mon, Apr 28, 2014 at 02:22:21PM +0200, Matthieu Moy wrote: >> >> I'd be OK with doing the moral equivalent for now (perhaps just taking >> Junio's proposal[1]), and I can deal with the refactoring later when >> re-rolling the Makefile series. >> >> -Peff >> >> [1] http://article.gmane.org/gmane.comp.version-control.git/240637 > > I doubt we would want to use the patch verbatim in that message; it > served its purpose well to illustrate that there may be other ways > to address the issue, but I agreed with the flaw in it you pointed > out in the thread [*1*] > > I also agree that droppage of S does not have to wait for that > topic.
So, shall I rewrite my patch on top of master? (not hard, but there will be a minor conflict to resolve when merging with Peff's cooking series).
-- Matthieu Moy http://www-verimag.imag.fr/~moy/