git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFCv5 3/3] git rebase -i: add static check for commands and SHA-1

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 15, 2015, 08:25 UTC
Message-ID
<vpqzj4174zb.fsf@anie.imag.fr>
In-Reply-To
<775816946.447663.1434237425837.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
Show 17 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>> Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
>> 
>> > It is mainly because here the SHA-1 is a long one (40 chars)
>> 
>> OK, but then the minimum would be to add a comment saying that.
>> 
>> Now, this makes me wonder why you are doing the check after the sha1
>> expansion and not before. Also, when running `git bisect --edit-todo`, I
>> do get the short sha1. So, there's a piece of code doing what you want
>> somewhere already. You may want to use it.
>
> Originally I did the whole checking after the expansion because I
> though that it was a better idea to avoid doing it myself (Comparing
> the whole SHA-1 instead of partial ones to find missing ones made more
> sense for me since otherwise I would have to check if one is the
> prefix of the other or expand to the same size before comparing).

Checking the missing commits after expansion makes sense (but it is only a matter of adding "| git rev-list --no-walk --stdin" somewhere in the pipeline).

But IMHO, checking the syntax errors is better done as early as possible if you want accurate error messages. This way you still have what the user typed available.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Remi Galan Alfonso
Message 12 of 12 in “git-rebase -i: add command "drop" to remove a commit”
  1. 1/3 git-rebase -i: add command "drop" to remove a commitGalan Rémi, Jun 10, 2015
  2. 2/3 git rebase -i: warn about removed commitsGalan Rémi, Jun 10, 2015
  3. Matthieu MoyJun 10, 2015
  4. Remi Galan AlfonsoJun 10, 2015
  5. Matthieu MoyJun 10, 2015
  6. Remi Galan AlfonsoJun 10, 2015
  7. 3/3 git rebase -i: add static check for commands and SHA-1Galan Rémi, Jun 10, 2015
  8. Matthieu MoyJun 10, 2015
  9. Remi Galan AlfonsoJun 10, 2015
  10. Matthieu MoyJun 10, 2015
  11. Remi Galan AlfonsoJun 13, 2015
  12. Matthieu MoyJun 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.