From: Matthieu Moy Date: Mon, 15 Jun 2015 08:25:44 GMT Subject: Re: [PATCH/RFCv5 3/3] git rebase -i: add static check for commands and SHA-1 Message-ID: In-Reply-To: <775816946.447663.1434237425837.JavaMail.zimbra@ensimag.grenoble-inp.fr> Remi Galan Alfonso writes: > Matthieu Moy writes: >> Remi Galan Alfonso writes: >> >> > It is mainly because here the SHA-1 is a long one (40 chars) >> >> OK, but then the minimum would be to add a comment saying that. >> >> Now, this makes me wonder why you are doing the check after the sha1 >> expansion and not before. Also, when running `git bisect --edit-todo`, I >> do get the short sha1. So, there's a piece of code doing what you want >> somewhere already. You may want to use it. > > Originally I did the whole checking after the expansion because I > though that it was a better idea to avoid doing it myself (Comparing > the whole SHA-1 instead of partial ones to find missing ones made more > sense for me since otherwise I would have to check if one is the > prefix of the other or expand to the same size before comparing). Checking the missing commits after expansion makes sense (but it is only a matter of adding "| git rev-list --no-walk --stdin" somewhere in the pipeline). But IMHO, checking the syntax errors is better done as early as possible if you want accurate error messages. This way you still have what the user typed available. -- Matthieu Moy http://www-verimag.imag.fr/~moy/