Re: [PATCH v1] travis-ci: build documentation
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Lars Schneider <larsxschneider@gmail.com> writes:
>>
>>>> There also are existing instances of "useless ;" that would want to
>>>> be cleaned up regardless of portability issues.
>>> Unfortunately it seems to be required. Travis CI generates a shell script
>>> out of the yml file and I think they don't respect newlines or something...
>>
>> If they squash all the lines into a single long line before
>> executing, these semicolons do indeed become necessary (we have to
>> write a logical single line shell script in our Makefiles with ';',
>> and I'd imagine Travis's scriptlets are done similarly).
Actually, it's not Travis, but just the Yaml syntax:
http://docs.ansible.com/ansible/YAMLSyntax.html
Values can span multiple lines using | or >. Spanning multiple lines
using a | will include the newlines. Using a > will ignore newlines;
it’s used to make what would otherwise be a very long line easier to
read and edit
So, a simpler solution would be to apply something like this:
--- a/.travis.yml
+++ b/.travis.yml
@@ -33,7 +33,7 @@ env:
- GIT_SKIP_TESTS="t9810 t9816"
before_install:
- - >
+ - |
case "${TRAVIS_OS_NAME:-linux}" in
linux)
mkdir --parents custom/p4
@@ -81,7 +81,7 @@ before_script: make --jobs=2
script: make --quiet test
after_failure:
- - >
+ - |
: '<-- Click here to see detailed test output!
';
for TEST_EXIT in t/test-results/*.exit;
do
(untested)
Actually, this may also be a motivation to move anything non-trivial out
of .travic.yml and to start using separate scripts (to avoid writting
shell within a Yaml syntax).
> ... but the above does not quite explain it. The newlines are
> mostly honoured as logical end-of-line in existing .travis.yml e.g.
> we do not see a semicolon before "pushd".
>
> case "${TRAVIS_OS_NAME:-linux}" in
> linux)
> mkdir --parents custom/p4
> pushd custom/p4
I'm tempted to think that these lines create directories pushd/ and
custom/p4/, but that doesn't quite explain it either. There's more magic
somewhere ...
> Puzzled...
Likewise.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Matthieu Moy <matthieu.moy@grenoble-inp.fr>