Re: [PATCH v1] travis-ci: build documentation

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Apr 25, 2016, 09:26 UTC
Message-ID: <vpqr3duyr85.fsf@anie.imag.fr>
In-Reply-To: <xmqqinz9pl3l.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> larsxschneider@gmail.com writes:
>>
>>> +      if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]];
>>
>> [[ is a bashism, and doesn't bring anything here compared to the POSIX
>> [ ... ], or "test" which is prefered in Git's source code.
>>
>> The ; or the newline is not needed either.
>
> Honestly, I didn't know that we were even trying to be pure POSIX,
> avoid bashism or GNUism, or in general to follow our shell scripting
> style in the scriptlet in the .travis.yml file.

I'm not implying that we should absolutely avoid non-POSIX constructs, just that the conjuction "non-POSIX + not useful" made me prefer to remain POSIX.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/