Re: [PATCH] Make the 'lock file exists' error more informative
- From
Matthieu Moy <matthieu.moy@imag.fr>
- Date
- Mar 4, 2009, 15:54 UTC
- Message-ID
- <vpqvdqpb7w6.fsf@bauges.imag.fr>
- In-Reply-To
- <1236179277-12477-1-git-send-email-johnflux@gmail.com>
John Tapsell <johnflux@gmail.com> writes:
> It looks like someone did 90% of the work, then forgot to actually use > the function
someone = me ;-).
The message is a bit inacurrate: the function is already used in two places, I just didn't notice this one.
> - if (errno == EEXIST) {
> + if (err == EEXIST) {Oops, right.
> - die("unable to create '%s.lock': %s", path, strerror(errno));
> + unable_to_lock_index_die(path, errno);Actually, _this_ instance is still to be fixed in next. You probably looked at the other one that my original message fixes.
IOW:
Acked-by: Matthieu Moy <Matthieu.Moy@imag.fr>
-- Matthieu