Re: [PATCH] Make the 'lock file exists' error more informative
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 4, 2009, 17:55 UTC
- Message-ID
- <7veixd5g1r.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <vpqvdqpb7w6.fsf@bauges.imag.fr>
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
Show 20 quoted lines
> John Tapsell <johnflux@gmail.com> writes:
>
>> It looks like someone did 90% of the work, then forgot to actually use
>> the function
>
> someone = me ;-).
>
> The message is a bit inacurrate: the function is already used in two
> places, I just didn't notice this one.
>
>> - if (errno == EEXIST) {
>> + if (err == EEXIST) {
>
> Oops, right.
>
>> - die("unable to create '%s.lock': %s", path, strerror(errno));
>> + unable_to_lock_index_die(path, errno);
>
> Actually, _this_ instance is still to be fixed in next. You probably
> looked at the other one that my original message fixes.Not in 'next', but in the maintenance track of v1.6.2.X and merged upwards, as v1.6.2~11^2~2 (More friendly message when locking the index fails., 2009-02-19) is obviously in v1.6.2 just released.
John, congratulations for fixing the first bug immediately after a big release. Please make it a habit to sign off your patches.