git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3 2/2] Warnings before amending published history

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 12, 2012, 07:34 UTC
Message-ID
<vpqvcixyoed.fsf@bauges.imag.fr>
In-Reply-To
<1339451781-29324-2-git-send-email-Lucien.Kong@ensimag.imag.fr>
Lucien Kong <Lucien.Kong@ensimag.imag.fr> writes:
>  builtin/commit.c              |   82 ++++++++++++++++++++++++++
>  sha1_name.c                   |   95 +++++++-----------------------
>  sha1_name.h                   |  130 +++++++++++++++++++++++++++++++++++++++++

I'm surprised that you need such a big patch. Basically, you're making all static functions in sha1_name.c public. If you really need such intrusive change, then you should at least explain why in the commit message, and most preferably split the patch into one refactoring patch to expose the functions and one to use them.

But I suspect what you're looking for is already in cache.h.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Lucien KongNext: Junio C Hamano
Message 23 of 25 in “Warnings before rebasing -i published history”
  1. Warnings before rebasing -i published historyLucien Kong, Jun 7, 2012
  2. Matthieu MoyJun 7, 2012
  3. konglu@minatec.inpg.frJun 8, 2012
  4. Matthieu MoyJun 8, 2012
  5. Junio C HamanoJun 8, 2012
  6. Junio C HamanoJun 7, 2012
  7. konglu@minatec.inpg.frJun 8, 2012
  8. Matthieu MoyJun 8, 2012
  9. Tomas CarneckyJun 8, 2012
  10. Matthieu MoyJun 8, 2012
  11. Junio C HamanoJun 8, 2012
  12. [PATCHv2] Warnings before rebasing -i published historyLucien Kong, Jun 11, 2012
  13. Matthieu MoyJun 11, 2012
  14. konglu@minatec.inpg.frJun 11, 2012
  15. Matthieu MoyJun 11, 2012
  16. branch --contains is unbearably slow [Re: [PATCHv2] Warnings before rebasing -i published history]Thomas Rast, Jun 11, 2012
  17. Junio C HamanoJun 11, 2012
  18. Thomas RastJun 11, 2012
  19. Thomas RastJun 11, 2012
  20. Junio C HamanoJun 11, 2012
  21. 1/2 Warnings before rebasing -i published historyLucien Kong, Jun 11, 2012
  22. 2/2 Warnings before amending published historyLucien Kong, Jun 11, 2012
  23. Matthieu MoyJun 12, 2012
  24. Junio C HamanoJun 12, 2012
  25. Nguy ThomasJun 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.