Re: [PATCHv2] Warnings before rebasing -i published history
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jun 11, 2012, 11:39 UTC
- Message-ID
- <vpqehpm5b8e.fsf@bauges.imag.fr>
- In-Reply-To
- <20120611133618.Horde.ife5dHwdC4BP1dgywnBALiA@webmail.minatec.grenoble-inp.fr>
konglu@minatec.inpg.fr writes:
Show 16 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> a écrit : > >> Lucien Kong <Lucien.Kong@ensimag.imag.fr> writes: >> >>> "git rebase -i" can be very dangerous if used on an already published >>> history. This code detects that one is rewriting a commit that is an >>> ancestor of a remote-tracking branch, and warns the user through the >>> editor. This feature is controlled by a new config key >>> rebase.checkremoterefs. >> >> For the lazy, you could provide an example of result in the commit >> message. People don't want to review how the patch is written if they >> disagree with the result. > > Right, but wouldn't it be better to put the example in the doc > git-rebase.txt ?
Why not. In any case, it should be easy to find for reviewers (I had to dig a little to find the expected value in the tests).
-- Matthieu Moy http://www-verimag.imag.fr/~moy/