Re: [PATCH 3/4] Git.pm: Add interface for git credential command.
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Feb 7, 2013, 07:19 UTC
- Message-ID
- <vpqvca4vbe9.fsf@grenoble-inp.fr>
- In-Reply-To
- <f4b5413b0a55474346daa7b0866c7a4fed55778d.1360183427.git.mina86@mina86.com>
Michal Nazarewicz <mpn@google.com> writes:
> From: Michal Nazarewicz <mina86@mina86.com> > > Add a credential() function which is an interface to the > git credential command.
Nice.
I think you should credit git-remote-mediawiki for the code in the commit message. Perhaps have a first "copy/paste" commit, and then an "adaptation" commit to add sort, ^ anchor in regexp, doc and your callback mechanism, but I won't insist on that.
Other than that, it all looks good, thanks. I'll take care of deleting the old code in git-remote-mediawiki and use Git.pm instead.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/